Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backend] optionnal STIX_EXT_OCTI_SCO #9088

Merged
merged 1 commit into from
Dec 2, 2024
Merged

[backend] optionnal STIX_EXT_OCTI_SCO #9088

merged 1 commit into from
Dec 2, 2024

Conversation

marieflorescontact
Copy link
Member

@marieflorescontact marieflorescontact commented Nov 19, 2024 •
edited
Loading

Proposed changes

  • STIX_EXT_OCTI_SCO is now optionnal

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Nov 19, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 65.17%. Comparing base (72aa9e5) to head (e5d7070).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...raphql/src/modules/playbook/playbook-components.ts 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #9088   +/-   ##
=======================================
  Coverage   65.17%   65.17%           
=======================================
  Files         624      624           
  Lines       59536    59536           
  Branches     6618     6619    +1     
=======================================
+ Hits        38800    38805    +5     
+ Misses      20736    20731    -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marieflorescontact marieflorescontact marked this pull request as ready for review November 20, 2024 11:16
@marieflorescontact marieflorescontact self-assigned this Nov 20, 2024
@marieflorescontact marieflorescontact merged commit f876260 into master Dec 2, 2024
6 checks passed
@marieflorescontact marieflorescontact deleted the issue/6409 branch December 2, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SarahBocognano SarahBocognano SarahBocognano approved these changes

@labo-flg labo-flg Awaiting requested review from labo-flg

Assignees

@marieflorescontact marieflorescontact

Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marieflorescontact @SarahBocognano